Messages in this thread | | | Date | Tue, 15 Jan 2013 16:53:30 +0400 | From | Sergei Shtylyov <> | Subject | Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part of control module |
| |
Hello.
On 15-01-2013 12:42, Kishon Vijay Abraham I wrote:
> A seperate driver has been added to handle the usb part of control > module. A device for the above driver is created here, using the register > address information to be used by the driver for powering on the PHY and > for writing to the mailbox.
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > arch/arm/mach-omap2/devices.c | 50 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+)
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > index 5e304d0..a761faf4 100644 > --- a/arch/arm/mach-omap2/devices.c > +++ b/arch/arm/mach-omap2/devices.c [...] > @@ -254,6 +255,54 @@ static inline void omap_init_camera(void) > #endif > } > > +#if (defined(CONFIG_OMAP_CONTROL_USB) || \ > + defined(CONFIG_OMAP_CONTROL_USB_MODULE))
() around || not needed, and you're indenting the second line too much.
> +static inline void __init omap_init_control_usb(void) > +{ > + int ret = 0;
Initializer not needed.
> + > + if (cpu_is_omap44xx()) { > + ret = platform_device_register(&omap4_control_usb); > + if (ret) > + pr_err("Error registering omap_control_usb device: %d\n" > + , ret);
Please leave the comma on the previous line.
WBR, Sergei
| |