Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v8 22/22] PCI: move device_add out of pci_bus_add_device() | Date | Tue, 15 Jan 2013 12:19:57 +0100 |
| |
On Monday, January 14, 2013 11:10:36 PM Yinghai Lu wrote: > On Sat, Jan 12, 2013 at 3:54 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > >> Move out device registering out of pci_bus_add_devices, so we could > >> put new created pci devices in device tree early. > >> > >> new pci_bus_add_devices will do the device_attach work to load pci drivers > >> instead. > > > > I wonder what problem it solves? > > we want to put created pci device in the device tree as soon as possible. > so for_pci_dev will not miss them. > > but at that time, we can not load driver for them yet. need to after > pci_assign_unsigned_resources etc to make sure all pci devices get > resource allocated at first. > > so only move adding to device tree early, and leave loading driver on > the old places.
I see, thanks.
Perhaps you can put that explanation into the changelog? It would help people to understand the reason for the change in the future.
Thanks, Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |