lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: add support for Sony RF receiver with USB product id 0x0374
Hi Antonio,

On 2013/01/15 18:36, Antonio Ospite wrote:
> On Tue, 15 Jan 2013 12:43:48 +0900 Fernando Luis Vázquez Cao <fernando_b1@lab.ntt.co.jp> wrote:
>> diff -urNp linux-3.8-rc3-orig/drivers/hid/hid-sony.c linux-3.8-rc3/drivers/hid/hid-sony.c
>> --- linux-3.8-rc3-orig/drivers/hid/hid-sony.c 2012-12-11 12:30:57.000000000 +0900
>> +++ linux-3.8-rc3/drivers/hid/hid-sony.c 2013-01-13 18:21:19.901347327 +0900
>> @@ -44,19 +44,21 @@ static __u8 *sony_report_fixup(struct hi
>> struct sony_sc *sc = hid_get_drvdata(hdev);
>>
>> if ((sc->quirks & VAIO_RDESC_CONSTANT) &&
>> - *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> - hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
>> + *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> + hid_info(hdev,
>> + "Fixing up Sony RF Receiver report descriptor\n");
> Changing the message does make sense, but try to avoid mixing
> functional changes with style changes (I am referring to the change of
> indentation here).

Oops, that was unintended. I will be replying to this email with an
updated version.

Thanks,
Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-15 11:42    [W:0.062 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site