lkml.org 
[lkml]   [2013]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width
From
On Tue, Jan 15, 2013 at 11:01 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On Tue, Jan 15, 2013 at 12:35 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>>> The details of the patch are fine, but i didn't get how do you get
>>> master 1 selected
>>> on a system where you have only 1 master?
>>
>> min_t(..., nr_masters - 1, m) defines this. m is returned value with
>> default settings, let's say 1. In that case if nr_masters is also 1
>> the min_t(..., 1-1, 1) returns 0.
>>
>> The value of nr_masters itself is come from autoconfig or platform data.
>
> :)
> You didn't get me. How this code would work is pretty easy to understand.
> What i wanted to know is, the master information is coming from slave drivers
> and they must select master zero always. How would master 1 be selected ever
> in this driver.

You forgot the mem2mem type of transfers where we have no information
about masters except default settings. Otherwise there is the case of
custom slave config absence when we supply only request line via
slave_id.

In the rest you are right.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2013-01-15 10:43    [W:0.047 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site