Messages in this thread | | | Date | Tue, 15 Jan 2013 17:19:06 -0800 | From | Dave Hansen <> | Subject | Re: [PATCH 02/17] mmzone: add various zone_*() helper functions. |
| |
On 01/15/2013 04:24 PM, Cody P Schafer wrote: > +static inline bool zone_spans_pfn(const struct zone *zone, unsigned long pfn) > +{ > + return zone->zone_start_pfn <= pfn && pfn < zone_end_pfn(zone); > +}
This needs some parenthesis, just for readability. There's also no crime in breaking it up to be multi-line if you want.
> +static inline bool zone_is_initialized(struct zone *zone) > +{ > + return !!zone->wait_table; > +} > + > +static inline bool zone_is_empty(struct zone *zone) > +{ > + return zone->spanned_pages == 0; > +}
| |