Messages in this thread | | | Date | Tue, 15 Jan 2013 17:16:33 -0800 | From | "H. Peter Anvin" <> | Subject | Re: your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops" |
| |
On 01/14/2013 01:02 AM, Jan Beulich wrote: >> >> What's "properly"? Doing extra 8042 detection somewhere else does not look >> right. > > Why? >
Because it is time consuming, and threatens to step on things.
Enabling A20 is one thing, but this is something else... if we have the KBC, we want to enable A20 *again* just in case. Having the i8042 code in one place makes sense to me. This doesn't have to be done early. The affected systems are *extremely* unlikely to ever be run without the i8042 driver loaded, and the failure mode benign enough (if you actually want to run a specific laptop without the keyboard driver, you can't suspend it) that there really is no point to have yet another driver for the same hardware that would stomp on each other.
-hpa
| |