Messages in this thread Patch in this message | | | From | Cody P Schafer <> | Subject | [PATCH 08/17] mm/page_alloc: use zone_spans_pfn() instead of open coded checks. | Date | Tue, 15 Jan 2013 16:24:45 -0800 |
| |
From: Cody P Schafer <jmesmon@gmail.com>
In 2 VM_BUG()s, avoid open coding zone ownership of pfns.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> --- mm/page_alloc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3911c1a..c5d70ce 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -242,9 +242,7 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) do { seq = zone_span_seqbegin(zone); - if (pfn >= zone->zone_start_pfn + zone->spanned_pages) - ret = 1; - else if (pfn < zone->zone_start_pfn) + if (!zone_spans_pfn(zone, pfn)) ret = 1; } while (zone_span_seqretry(zone, seq)); @@ -5639,8 +5637,7 @@ void set_pageblock_flags_group(struct page *page, unsigned long flags, pfn = page_to_pfn(page); bitmap = get_pageblock_bitmap(zone, pfn); bitidx = pfn_to_bitidx(zone, pfn); - VM_BUG_ON(pfn < zone->zone_start_pfn); - VM_BUG_ON(pfn >= zone->zone_start_pfn + zone->spanned_pages); + VM_BUG_ON(!zone_spans_pfn(zone, pfn)); for (; start_bitidx <= end_bitidx; start_bitidx++, value <<= 1) if (flags & value) -- 1.8.0.3
| |