lkml.org 
[lkml]   [2013]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectyour patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"
Ondrej,

I see two problems with this patch: For one, on a system without
i8042 the code at the place it got inserted ought to incur a stall of
1s (50us * I8042_CTL_TIMEOUT [10000] * 2). I believe that this
code should not be run before i8042_controller_check() completed
successfully, but at the very least the second call to
i8042_command() should be conditional upon the first being
successful (effectively halving the stall).

Second, considering that enabling A20 (even if just in a fake way),
is a core system operation, I don't think it belongs into a driver
that is only optionally present in the kernel.

Jan



\
 
 \ /
  Last update: 2013-01-14 09:43    [W:2.434 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site