Messages in this thread Patch in this message | | | From | Cong Ding <> | Subject | [PATCH] dma: remove unnecessary null pointer check in mmp_pdma.c | Date | Tue, 15 Jan 2013 01:19:48 +0100 |
| |
the pointer cfg is dereferenced in line 594, so it's no reason to check null again in line 620.
Signed-off-by: Cong Ding <dinggnu@gmail.com> --- drivers/dma/mmp_pdma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index c6d98c0..81d7b89 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -617,10 +617,8 @@ static int mmp_pdma_control(struct dma_chan *dchan, enum dma_ctrl_cmd cmd, else if (maxburst == 32) chan->dcmd |= DCMD_BURST32; - if (cfg) { - chan->dir = cfg->direction; - chan->drcmr = cfg->slave_id; - } + chan->dir = cfg->direction; + chan->drcmr = cfg->slave_id; chan->dev_addr = addr; break; default: -- 1.7.10.4
| |