lkml.org 
[lkml]   [2013]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] usb: phy: samsung: Add support to set pmu isolation
From
Vivek,

Sorry for being so absent from these reviews. I'll try to look over a
few patches today, but please don't hold up anything on account of my
reviews. I'm definitely a bit of an interested bystander in USB land.
;)

In general things look pretty good here. :) One last comment below...

On Fri, Jan 11, 2013 at 12:08 AM, Vivek Gautam
<gautam.vivek@samsung.com> wrote:> +static int
samsung_usbphy_parse_dt(struct samsung_usbphy *sphy)
> +{
> + struct device_node *usbphy_sys;
> +
> + /* Getting node for system controller interface for usb-phy */
> + usbphy_sys = of_get_child_by_name(sphy->dev->of_node, "usbphy-sys");
> + if (!usbphy_sys)
> + dev_warn(sphy->dev, "No sys-controller interface for usb-phy\n");

Seems like you ought to return with an error here. Calling of_iomap()
with a NULL value seems undesirable.

> +
> + sphy->pmuregs = of_iomap(usbphy_sys, 0);
> +
> + of_node_put(usbphy_sys);
> +
> + if (sphy->pmuregs == NULL) {
> + dev_err(sphy->dev, "Can't get usb-phy pmu control register\n");
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
> +
> +/*
> + * Set isolation here for phy.
> + * Here 'on = true' would mean USB PHY block is isolated, hence
> + * de-activated and vice-versa.
> + */

Thank you very much for this comment. :) This explains one of the
confusions I had earlier...


Once you fix the one error condition above you can add my
"Reviewed-by". Thanks!

-Doug


\
 
 \ /
  Last update: 2013-01-14 23:42    [W:0.414 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site