lkml.org 
[lkml]   [2013]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Hashtable implementation breaks on flow statements
Hi Franz,

The hashtable should behave correctly (that is, not continue iteration
from the next
bucket) with regards to a 'break' inside the loop, this issue was
raised previously
during one of the RFCs and has been dealt with before the merge of the hashtable
into the kernel.

Do you see a case where it behaves incorrectly? can you share your code which
does that?


Thanks,
Sasha

On Mon, Jan 14, 2013 at 5:51 AM, Schrober <franzschrober@yahoo.de> wrote:
> Hi,
>
> I think the new hash implementation in include/linux/hashtable.h is slightly
> unintuitive when using things like hash_for_each, hash_for_each_rcu,
> hash_for_each_safe and hash_for_each_possible.
>
> Users may want to get out of the loop through the hashtable iteration when
> some condition is met. This works well on hlist, list and other "abstract"
> data types. But the hash table would just jump to the next bucket and
> continue.
> --
> Franz Schrober


\
 
 \ /
  Last update: 2013-01-14 21:41    [W:0.568 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site