Messages in this thread Patch in this message | | | Subject | Re: [PATCH 04/18] power: ab8500_fg: Replace msleep() with usleep_range() for greater accuracy | From | Joe Perches <> | Date | Mon, 14 Jan 2013 09:17:37 -0800 |
| |
On Fri, 2013-01-11 at 13:12 +0000, Lee Jones wrote: > Doing so provides a greater degree of accuracy when dealing with > time-frames between 1us and 20ms. msleep() is only accurate for > wake-ups greater than 20ms. [] > diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c [] > @@ -956,7 +956,7 @@ static int ab8500_fg_load_comp_volt_to_capacity(struct ab8500_fg *di) > do { > vbat += ab8500_fg_bat_voltage(di); > i++; > - msleep(5); > + usleep_range(5000, 5001);
If you're going to give a range that small you might as well use usleep instead.
Otherwise, add some tolerance to allow any other coalesced wakeup to occur.
| |