Messages in this thread | | | Date | Sat, 12 Jan 2013 18:06:55 +0100 | From | Oleg Nesterov <> | Subject | Re: [RFC PATCH 5/6] uprobes: add bp_vaddr argument to consumer handler |
| |
On 01/10, Josh Stone wrote: > > For uprobes, systemtap wants regs->ip to be the real breakpoint address,
Just to be sure this didn't escape your attention... Please note that this becomes true after
[PATCH 2/2] uprobes: Change handle_swbp() to expose bp_vaddr to handler_chain() http://marc.info/?l=linux-kernel&m=135688247630262
so you should no longer use uprobe_get_swbp_addr or inst->vaddr to change regs->ip.
> and for uretprobes we want the original return address.
Yes, Anton's v2 does this.
But. Don't you also need to know the address of function we are going to return from?
Probably you do not, uprobe_consumer should know which function (but not vaddr) it probes, but please confirm.
Oleg.
| |