lkml.org 
[lkml]   [2013]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [tip:x86/build] x86: Default to ARCH= x86 to avoid overriding CONFIG_64BIT
    On Thu, Dec 20, 2012 at 06:07:46PM -0800, tip-bot for David Woodhouse wrote:
    > Commit-ID: ffee0de411fd4f74f3b788892eeb075abbf26c52
    > Gitweb: http://git.kernel.org/tip/ffee0de411fd4f74f3b788892eeb075abbf26c52
    > Author: David Woodhouse <dwmw2@infradead.org>
    > AuthorDate: Thu, 20 Dec 2012 21:51:55 +0000
    > Committer: H. Peter Anvin <hpa@linux.intel.com>
    > CommitDate: Thu, 20 Dec 2012 14:37:18 -0800
    >
    > x86: Default to ARCH=x86 to avoid overriding CONFIG_64BIT
    >
    > It is easy to waste a bunch of time when one takes a 32-bit .config
    > from a test machine and try to build it on a faster 64-bit system, and
    > its existing setting of CONFIG_64BIT=n gets *changed* to match the
    > build host. Similarly, if one has an existing build tree it is easy
    > to trash an entire build tree that way.
    >
    > This is because the default setting for $ARCH when discovered from
    > 'uname' is one of the legacy pre-x86-merge values (i386 or x86_64),
    > which effectively force the setting of CONFIG_64BIT to match. We should
    > default to ARCH=x86 instead, finally completing the merge that we
    > started so long ago.

    Ok, I don't know whether this was on purpose or not but setting ARCH=x86
    has the side effect of putting the config 64BIT prompt into the toplevel
    menuconfig:

    [*] 64-bit kernel
    General setup --->
    [*] Enable loadable module support --->
    [*] Enable the block layer --->
    Processor type and features --->

    Now, IMHO, maybe the more fitting place for this should be "Processor
    type and features" where all the arch-specific stuff goes but looking at
    arch/x86/Kconfig, it would need some restructuring due to dependencies.

    So how about we simply hide it by still preserving the functionality:

    --
    diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
    index 50b1b1bf442b..e8d7e9250853 100644
    --- a/arch/x86/Kconfig
    +++ b/arch/x86/Kconfig
    @@ -1,6 +1,7 @@
    # Select 32 or 64 bit
    config 64BIT
    - bool "64-bit kernel" if ARCH = "x86"
    + bool
    + default y if ARCH = "x86"
    default ARCH != "i386"
    ---help---
    Say yes to build a 64-bit kernel - formerly known as x86_64
    Thanks.

    --
    Regards/Gruss,
    Boris.

    Sent from a fat crate under my desk. Formatting is fine.
    --


    \
     
     \ /
      Last update: 2013-01-12 19:01    [W:3.165 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site