Messages in this thread | | | Date | Sat, 12 Jan 2013 17:38:40 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH] uprobes: Add exports for module use |
| |
On 01/11, Christoph Hellwig wrote: > > On Thu, Jan 10, 2013 at 03:01:46PM -0800, Josh Stone wrote: > > The original pull message for uprobes (commit 654443e2) noted: > > > > This tree includes uprobes support in 'perf probe' - but SystemTap > > (and other tools) can take advantage of user probe points as well. > > > > In order to actually be usable in module-based tools like SystemTap, the > > interface needs to be exported. This patch first adds the obvious > > exports for uprobe_register and uprobe_unregister. Then it also adds > > one for task_user_regset_view, which is necessary to get the correct > > state of userspace registers. > > Get systemtap into the mainline kernel tree and we can talk.
I can't understand your reply.
Looks like, you do not like the fact that uprobes can be used by the out of tree modules. Why?
And why, say, kprobe_register() is exported then? Afaics, it does not have any modular in-kernel user.
As for systemtap in particular. I never used it, and probably you didn't. But it has a lot of users, and I know many people who find it very useful.
Oleg.
| |