lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctl support (v2)
Date
Here is the second revision at implementing compat_ioctl support for
Android's alarm-dev driver in staging.

The first patch removes the pre-Android 1.0 _OLD ioctls, per Colin's
suggestion. Then the second patch does some refactoring to cleanup
and separate the copying of user data from the logic, and the final
patch adds the compat_ioctl support.

I've tested this with a trivial unit test compiled for both 32bit
and 64bit on a x86_64 kernel, and it looks ok, but closer review
would be appreciated to make sure I didn't break anything.

Additional feedback or thoughts would be welcome!

thanks
-john

Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Colin Cross <ccross@google.com>
Cc: Android Kernel Team <kernel-team@android.com>

John Stultz (3):
staging: alarm-dev: Drop pre Android 1.0 _OLD ioctls
staging: alarm-dev: Refactor alarm-dev ioctl code in prep for
compat_ioctl
staging: alarm-dev: Implement compat_ioctl support

drivers/staging/android/alarm-dev.c | 277 +++++++++++++++++++------------
drivers/staging/android/android_alarm.h | 19 +++
2 files changed, 193 insertions(+), 103 deletions(-)

--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-12 01:21    [W:0.070 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site