lkml.org 
[lkml]   [2013]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/16] ACPI: Separate adding ACPI device objects from probing ACPI drivers
(Sorry to jump in late but I noticed one problem with this series while
testing).

On Thu, Dec 20, 2012 at 02:47:47AM +0100, Rafael J. Wysocki wrote:
> +static acpi_status acpi_bus_probe_start(acpi_handle handle, u32 lvl,
> + void *context, void **not_used)
> +{
> + struct acpi_bus_ops *ops = context;
> + acpi_status status = AE_OK;
> + struct acpi_device *device;
> + unsigned long long sta_not_used;
> + int type_not_used;
> +
> + /*
> + * Ignore errors ignored by acpi_bus_check_add() to avoid terminating
> + * namespace walks prematurely.
> + */
> + if (acpi_bus_type_and_status(handle, &type_not_used, &sta_not_used))
> + return AE_OK;
> +
> + if (acpi_bus_get_device(handle, &device))
> + return AE_CTRL_DEPTH;
> +
> + if (ops->acpi_op_add) {
> + if (!acpi_match_device_ids(device, acpi_platform_device_ids)) {
> + /* This is a known good platform device. */
> + acpi_create_platform_device(device);
> + } else if (device_attach(&device->dev)) {

device_attach() returns 1 if it succeeds to attach device to a driver. In
that case we should continue and not return AE_CTRL_DEPTH, right?

> + status = AE_CTRL_DEPTH;
> + }
> + } else if (ops->acpi_op_start) {
> + if (ACPI_FAILURE(acpi_start_single_object(device)))
> + status = AE_CTRL_DEPTH;
> + }
> + return status;
> +}


\
 
 \ /
  Last update: 2013-01-11 21:21    [W:1.283 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site