Messages in this thread | | | Date | Fri, 11 Jan 2013 10:25:47 -0800 | From | Greg KH <> | Subject | Re: [PATCH 0/3] ixgbe: request_firmware for configuration parameters |
| |
On Thu, Jan 10, 2013 at 06:02:20PM -0800, Shannon Nelson wrote: > Most networking dials and knobs can be set using ethtool, ifconfig, ip link > commands, or sysfs entries, all of which can be driven by startup scripts > and other configuration tools. However, they all depend on having a netdev > already set up, and we have some low-level device functionality that needs > to be sorted out before we start setting up MSI-x and memory allocations. > > In order to do early device configuration, most kernel drivers use module > parameters whose settings can be persisted in modprobe.d config files. > However, these can be clumsy to use and manage, difficult to specify port > specific values in a multiport device, and are actively discouraged in > some circles. > > In this patchset, the driver uses the existing request_firmware() and > match_token() facilities to grab an ASCII config file from userspace to > find special startup-time configuration information that needs persistence > across reboots. The configuration strings are formed similar to the > mount options that get passed from /etc/fstab into filesystem modules.
Ick, please don't abuse request_firmware() for this type of thing.
What's wrong with configfs? It sounds like it will fit your need, and that is what is created for.
greg k-h
| |