Messages in this thread Patch in this message | | | From | Dmitry Torokhov <> | Subject | [PATCH 4/6] VMCI: Fix "always true condition" | Date | Thu, 10 Jan 2013 15:41:41 -0800 |
| |
From: Andy King <acking@vmware.com>
vmci_send_datagram() returns an int, with negative values indicating failure. But we store it locally in a u32, which makes comparison of >= 0 useless. Fixed to use an int.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andy King <acking@vmware.com> Signed-off-by: Dmitry Torokhov <dtor@vmware.com> --- drivers/misc/vmw_vmci/vmci_guest.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_guest.c b/drivers/misc/vmw_vmci/vmci_guest.c index d302c89..d7df6cf 100644 --- a/drivers/misc/vmw_vmci/vmci_guest.c +++ b/drivers/misc/vmw_vmci/vmci_guest.c @@ -78,7 +78,7 @@ bool vmci_guest_code_active(void) u32 vmci_get_vm_context_id(void) { if (vm_context_id == VMCI_INVALID_ID) { - u32 result; + int result; struct vmci_datagram get_cid_msg; get_cid_msg.dst = vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID, -- 1.7.4.1
| |