lkml.org 
[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 3/6] ACPI/pci_slot: update PCI slot information when PCI hotplug event happens
    From
    On Thu, Jan 10, 2013 at 1:50 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    > Well, I don't see what functional problems that can bring.
    >
    > In theory people may want to have them as modules to avoid loading them on
    > systems that don't use PCI hotplug, but honestly I think that the complexity
    > this causes us to deal with is not worth it.
    >
    > Moreover, removing the modularity may actually allow us to solve some ordering
    > issues once and for good.

    No, the world is not really ideal yet.

    looks like laptops have problem with pci express cards.

    when pciehp is used, surprise insert/removal does not work because
    PresDect does not change properly, so no interrupt is generated.
    --- i suspects that is silicon problem.

    but when acpiphp is used, that surprise insert/removal is working.

    some laptop like thinkpad, just don't give osc to kernel..
    [ 0.505117] pci0000:00: Requesting ACPI _OSC control (0x1d)
    [ 0.505413] pci0000:00: ACPI _OSC request failed (AE_SUPPORT),
    returned control mask: 0x0d
    [ 0.505517] ACPI _OSC control for PCIe not granted, disabling ASPM

    and other laptop give that to kernel, in recent kernel will not give
    acpiphp to have that slot, because it want to hold that for pciehp.
    poor user have to pass 'pci_aspm=off" to disable _OSC for all.
    --- please check the mail that i forward to you yesterday.

    Anyway, we do need to let the user to have choice to use acpiphp and pciehp.
    and it should be first come and first serve policy.

    Thanks

    Yinghai


    \
     
     \ /
      Last update: 2013-01-11 00:21    [W:4.105 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site