Messages in this thread | | | Subject | Re: [PATCH] gpio: vt8500: memory cleanup missing | From | Tony Prisk <> | Date | Fri, 11 Jan 2013 07:45:27 +1300 |
| |
On Thu, 2013-01-10 at 13:02 +0100, Linus Walleij wrote: > On Thu, Jan 10, 2013 at 11:57 AM, Russell King - ARM Linux > <linux@arm.linux.org.uk> wrote: > > On Thu, Jan 03, 2013 at 10:47:20AM +1300, Tony Prisk wrote: > > >> +static int vt8500_gpio_remove(struct platform_device *pdev) > >> +{ > >> + int i; > >> + int ret; > >> + const struct vt8500_gpio_data *data; > >> + void __iomem *gpio_base = vtchip[0].base; > >> + const struct of_device_id *of_id = > >> + of_match_device(vt8500_gpio_dt_ids, &pdev->dev); > >> + > > > > You can get at the vtchip pointer if you put it into the platform device's > > driver data pointer. That way, you're not artificially limiting this > > driver to just one device, and, with your changes it will go wrong if DT > > ever lists more than one device. > > Good point, I'm sloppy today :-( > > Patch dropped. > > Tony pls proceed as indicated by Russell. > > Yours, > Linus Walleij
I must have been having a 'stupid' day to not realise that. Will fix. Thanks Russell.
Regards Tony P
| |