lkml.org 
[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend 2/2] Input: twl6040-vibra: Code cleanup in probe with devm_* conversion
Hi Peter,

On Thu, Jan 10, 2013 at 02:36:05PM +0100, Peter Ujfalusi wrote:
> Convert the probe to use devm_*. At the same time reorder the calls
> so we will register the input device as the last step when the driver
> is loaded.

If you are doing this please also use devm_input_allocate_device() and
devm_regulator_bulk_get(). I alos think it is high time to get rid of
dedicated work queue - cwq hasn't actually given you a separate therad
for a while now and if you get rid of workqueue you can get ridof entire
twl6040_vibra_remove().

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2013-01-10 19:21    [W:0.039 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site