Messages in this thread | | | Date | Thu, 10 Jan 2013 17:59:42 +0100 | From | Jan Kara <> | Subject | Re: [PATCH 5/6] udf: implement extent caching while reading-writing to a file |
| |
On Wed 09-01-13 15:26:43, Namjae Jeon wrote: > 2012/12/13, Namjae Jeon <linkinjeon@gmail.com>: > > 2012/10/19, Namjae Jeon <linkinjeon@gmail.com>: > >> 2012/10/19, Jan Kara <jack@suse.cz>: > >>> Hello, > >>> > >>> On Wed 10-10-12 00:10:01, Namjae Jeon wrote: > >>>> From: Namjae Jeon <namjae.jeon@samsung.com> > >>>> > >>>> This patch implements extent caching. > >>>> Instead of reading metadata everytime from file's starting position, > >>>> now we read from the cached extent. > >>>> This speeds up the transformation of file logical offsets to > >>>> corresponding on-disk blocks. > >>> I have some mostly minor comments to the patch. But when reading the > >>> extent code it is just ugly and hard to follow. So I'm thinking how to > >>> improve that before making things even harder with the extent cache. So > >>> give me a few more days please. > >> Hi Jan. > >> Okay, I see. Thanks! > >>> > > Hi Jan. > > Sorry for interrupt. I am still waiting for your review. > > Would you check extent cache patches ? > > Thanks. > Hi Jan. > > Maybe You think you didn't convince extent cache implementation of > write part in this patch. > So I suggest that once, we add extent cache of read part first in case > of read-only mount type. > because it is real issue on 3D BD-disk playing(BD Disk is used on > read-only mount type). > And I will check more write part again. I'm sorry for not getting to you earlier. Yes, support for reading should be easy enough and we can add support for write when I finish the extent cleanup (I already have the new code written but I need to integrate it with the rest of UDF code...). Can you please send the patch for read support and I'll queue it for the next merge window? Thanks!
Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |