Messages in this thread | | | Date | Thu, 10 Jan 2013 06:28:29 -0800 | From | Greg KH <> | Subject | Re: [PATCH 5/9] Thermal: Create 'mapX' sysfs node for a zone |
| |
On Thu, Jan 10, 2013 at 12:50:20PM +0000, R, Durgadoss wrote: > > -----Original Message----- > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > owner@vger.kernel.org] On Behalf Of Greg KH > > Sent: Tuesday, January 08, 2013 12:51 AM > > To: R, Durgadoss > > Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; > > eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com > > Subject: Re: [PATCH 5/9] Thermal: Create 'mapX' sysfs node for a zone > > > > On Mon, Jan 07, 2013 at 12:43:22PM +0530, Durgadoss R wrote: > > > This patch creates a thermal map sysfs node under > > > /sys/class/thermal/zoneX/. This contains > > > entries named map0, map1 .. mapN. Each map has the > > > following space separated values: > > > trip_type sensor_name cdev_name trip_mask weights > > > > sysfs file are always "one value per file". This seems to violate that > > rule, so please rework this. > > These values together represent the binding information of > sensors and cooling devices in a zone. That's why we put > them in a single file.
That doesn't matter, it's still multiple values in a single file that has to be parsed now.
> >From our previous discussion, I understand we can support > a lot of nodes in sysfs. So, I will work with Rui to see how we can > split this in a meaningful way. > > Something like: > map0_trip_type > map0_sensor_name > map0_cdev_name > map0_mask > etc..
That would be much better.
thanks,
greg k-h
| |