Messages in this thread |  | | Date | Thu, 10 Jan 2013 18:18:35 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 5/7] uprobes: Fix utask->xol_vaddr leak in pre_ssout() |
| |
> > > utask->vaddr = bp_vaddr; > > > > > > - return arch_uprobe_pre_xol(&uprobe->arch, regs); > > > + err = arch_uprobe_pre_xol(&uprobe->arch, regs); > > > + if (unlikely(err)) { > > > + xol_free_insn_slot(current); > > > + return err; > > > + } > > > + > > > + return 0; > > > } > > > > Nit: we could reduce a line or two with > > > > err = arch_uprobe_pre_xol(&uprobe->arch, regs); > > if (unlikely(err)) > > xol_free_insn_slot(current); > > > > return err; > > Yes, but this is also preparation for the next patch which adds more > code after arch_uprobe_pre_xol() == 0. >
Agree
-- Thanks and Regards Srikar
|  |