lkml.org 
[lkml]   [2013]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] gpio: twl4030: Cache the direction and output states in private data
From
On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:

> Use more coherent locking in the driver. Use bitfield to store the GPIO
> direction and if the pin is configured as output store the status also in a
> bitfiled.
> In this way we can just look at these bitfields when we need information
> about the pin status and only reach out to the chip when it is needed.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi Grant,
>
> Changes sicne v2:
> - Fixed the mutex_unlock found by Michael.
> - Removed the debug prints addedd by v2 patch (remains from debugging)
> - Removed one blank line between includes and the first comment section.

Sorry Peter this must have been missed somehow.

This does not apply to the current v3.8-rc3, could you respin
this on top of Torvalds' tree?

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-01-10 12:21    [W:0.117 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site