lkml.org 
[lkml]   [2013]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH,staging/speakup] Prefix externally-visible symbols
On Tue, Jan 01, 2013 at 11:52:57PM +0100, Samuel Thibault wrote:
> This prefixes all externally-visible symbols of speakup with "spk_".
> (or makes static some of them which do not actually need to be
> externally-visible)

Care to break this up into smaller pieces? Like one for the variables
that should just be static? And then the other bits?

Also, I think you just changed user-visable variables/sysfs files, which
isn't acceptable. Be careful about that when you resend.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-01-02 02:41    [W:1.622 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site