Messages in this thread | | | Date | Sat, 8 Sep 2012 01:34:41 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH] [RFC]power: battery: Generic battery driver using IIO |
| |
On Sat, Sep 08, 2012 at 12:40:18PM +0530, anish kumar wrote: [...] > > > Signed-off-by: anish kumar <anish198519851985@gmail.com> > > So what happened in 1985? > Was hurrying to get an email id :)
I so much understand... ;-)
Much thanks to Lars-Peter and Jonathan, saved me a lot of time reviewing the driver.
Anish, the idea of generic IIO driver looks great, I'm impatiently waiting for a new revision!
One suggestion: the file name says generic-battery, the code sometimes uses generic_adc_battery sometimes generic_battery. I'd suggest being consistent, and stick to one naming scheme. I'd prefer generic_adc_battery.
Thanks!
Anton.
| |