Messages in this thread | | | Date | Sat, 8 Sep 2012 13:19:04 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 5/7] uprobes: Do not (ab)use TIF_SINGLESTEP/user_*_single_step() for single-stepping |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-09-07 17:50:57]:
> On 09/07, Srikar Dronamraju wrote: > > > > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> > > Thanks! > > (and thanks, I'll fix the typo in 2/7 you pointed out) > > > > void arch_uprobe_enable_step(struct arch_uprobe *auprobe) > > > { > > > - struct uprobe_task *utask = current->utask; > > > - struct arch_uprobe_task *autask = &utask->autask; > > > + struct task_struct *task = current; > > > > Any particular reason to use task instead of current? > > No particular reason, and I think in this case asm will be the same. > > Please let me know if you prefer to remove this variable, I'll redo > this patch.
No, the patch is fine.
I have no problem with the additional variable, I was just curious if you had any other plans that needed that a exta variable that alls.
-- thanks and regards Srikar
| |