lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 49/57] staging/rts_pstor: remove braces {} in sd.c (ext_sd_get_rsp)
    Date
    fixed below checkpatch warnings.
    -WARNING: braces {} are not necessary for single statement blocks

    Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
    ---
    drivers/staging/rts_pstor/sd.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
    index 4168af6..9091700 100644
    --- a/drivers/staging/rts_pstor/sd.c
    +++ b/drivers/staging/rts_pstor/sd.c
    @@ -3599,29 +3599,27 @@ int ext_sd_get_rsp(struct rtsx_chip *chip, int len, u8 *rsp, u8 rsp_type)
    int retval, rsp_len;
    u16 reg_addr;

    - if (rsp_type == SD_RSP_TYPE_R0) {
    + if (rsp_type == SD_RSP_TYPE_R0)
    return STATUS_SUCCESS;
    - }

    rtsx_init_cmd(chip);

    if (rsp_type == SD_RSP_TYPE_R2) {
    - for (reg_addr = PPBUF_BASE2; reg_addr < PPBUF_BASE2 + 16; reg_addr++) {
    + for (reg_addr = PPBUF_BASE2; reg_addr < PPBUF_BASE2 + 16; reg_addr++)
    rtsx_add_cmd(chip, READ_REG_CMD, reg_addr, 0xFF, 0);
    - }
    +
    rsp_len = 17;
    } else if (rsp_type != SD_RSP_TYPE_R0) {
    - for (reg_addr = REG_SD_CMD0; reg_addr <= REG_SD_CMD4; reg_addr++) {
    + for (reg_addr = REG_SD_CMD0; reg_addr <= REG_SD_CMD4; reg_addr++)
    rtsx_add_cmd(chip, READ_REG_CMD, reg_addr, 0xFF, 0);
    - }
    +
    rsp_len = 6;
    }
    rtsx_add_cmd(chip, READ_REG_CMD, REG_SD_CMD5, 0xFF, 0);

    retval = rtsx_send_cmd(chip, SD_CARD, 100);
    - if (retval != STATUS_SUCCESS) {
    + if (retval != STATUS_SUCCESS)
    TRACE_RET(chip, STATUS_FAIL);
    - }

    if (rsp) {
    int min_len = (rsp_len < len) ? rsp_len : len;
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-09-07 08:03    [W:4.285 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site