Messages in this thread | | | Subject | Re: [PATCH 0/5] dev_<level> and dynamic_debug cleanups | From | Joe Perches <> | Date | Fri, 07 Sep 2012 07:58:41 -0700 |
| |
On Thu, 2012-09-06 at 11:43 -0700, Joe Perches wrote: > On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: > > On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: > > > The recent commit to fix dynamic_debug was a bit unclean. > > > Neaten the style for dynamic_debug. > > > Reduce the stack use of message logging that uses netdev_printk > > > Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg. [] > > The one thing that is bothering me though, is that for > > __dynamic_dev_dbg(), __dynamic_netdev_dbg(), we are copying much of the core > > logic of __dev_printk(), __netdev_printk(), respectively. I would prefer > > have this in one place. Can we add a 'prefix' argument to __dev_printk(), > > and __netdev_printk() that dynamic debug can use, but is simply empty > > for dev_printk() and netdev_printk(). > > I don't think that's an improvement actually.
Because it would add an always effectively unused "" argument to dev_printk and netdev_printk calls in non dynamic_debug builds.
dynamic_debug is still mostly a developer feature and I believe most distros do not enable it.
| |