Messages in this thread Patch in this message | | | Date | Fri, 7 Sep 2012 17:17:18 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH 2/2] mm: support MIGRATE_DISCARD |
| |
Hi Kyungmin,
On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote: > On 9/7/12, Kyungmin Park <kmpark@infradead.org> wrote: > > Hi Minchan, > > > > I tested Mel patch again with ClearPageActive(page). but after some > > testing, it's stall and can't return from > > reclaim_clean_pages_from_list(&cc.migratepages). > > > > Maybe it's related with unmap feature from yours? > > stall is not happened from your codes until now. > > > > I'll test it more and report any issue if happened. > Updated. it's hang also. there are other issues.
It was silly mistake in my patch and I suspect it fixes your issue because I guess you already tried below patch when you compiled and saw warning message. Anyway, if you see hang still after applying below patch, please enable CONFIG_DEBUG_VM and retest, if you find something, report it. I hope CONFIG_DEBUG_VM catch something.
Thanks.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6668115..51d3f66 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5705,7 +5705,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned break; } - reclaim_clean_pages_from_list(&cc.migratepages, cc.zone); + reclaim_clean_pages_from_list(cc.zone, &cc.migratepages); ret = migrate_pages(&cc.migratepages, __alloc_contig_migrate_alloc, (END)
-- Kind regards, Minchan Kim
| |