lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, efi: 1:1 pagetable mapping for virtual EFI calls
>>> On 06.09.12 at 17:47, Matt Fleming <matt.fleming@intel.com> wrote:
> On Thu, 2012-09-06 at 15:34 +0100, Jan Beulich wrote:
>> >>> On 06.09.12 at 15:15, Matt Fleming <matt@console-pimps.org> wrote:
>> > + __flush_tlb_all();
>>
>> Is it certain you will _never_ hit a global mapping (in which case I
>> believe the above would be insufficient)?
>
> Are you saying that this should be a flush_tlb_all() if we have global
> mappings? Or that if we are guaranteed to never have global mappings we
> can opitmise this by simply doing a __flush_tlb()?

Hmm, looks like I shouldn't have worked from memory -
other than I remembered, __flush_tlb_all() does take care
of global pages. But indeed, if we can be sure that no global
mappings would ever exist in the replaced (low) part of the
address space, then __flush_tlb() would be sufficient. But I
would agree that for a first round (and possibly forever,
particularly as long as performance doesn't matter) it's safer
to use the more aggressive flush. So please disregard my
respective comment to that part of your patch.

Jan



\
 
 \ /
  Last update: 2012-09-07 10:01    [W:0.056 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site