lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] serial: mxs-auart: fix the wrong setting order
On Thu, Sep 06, 2012 at 10:38:40PM -0400, Huang Shijie wrote:
> After set the AUART_CTRL0_CLKGATE, the UART will gate all the clocks off.
> So the following line will not take effect.
> ................................................................
> writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN,
> u->membase + AUART_INTR_CLR);
> ................................................................
>
> To fix this issue, the patch moves this gate-off line to
> the end of setting registers.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

Are you experiencing any user visible problem with this bug?

Regards,
Shawn

> ---
> drivers/tty/serial/mxs-auart.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index dafeef2..ea5f888 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -457,11 +457,11 @@ static void mxs_auart_shutdown(struct uart_port *u)
>
> writel(AUART_CTRL2_UARTEN, u->membase + AUART_CTRL2_CLR);
>
> - writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET);
> -
> writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN,
> u->membase + AUART_INTR_CLR);
>
> + writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET);
> +
> clk_disable_unprepare(s->clk);
> }
>
> --
> 1.7.4.4
>


\
 
 \ /
  Last update: 2012-09-07 05:21    [W:0.099 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site