lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3] regulator: disable supply regulator if it is enabled for boot-on
On Mon, Sep 03, 2012 at 07:55:39PM +0530, Laxman Dewangan wrote:

> + /* If supply enabled during registrtaion then need to disable
> + * when full constraint enabled.
> + */
> + unsigned int need_supply_disable:1;

I don't understand why we need this flag. Shouldn't we just be making
the reference counts for the supplies correct and then have the
regulator disabled in the late initcall as a result of its refcount
falling to zero when the children are disabled? I think what we need to
do here is always take a reference to the supply if the child is enabled
during boot, then in the initcall we can just disable the parent
regulator as normal.


\
 
 \ /
  Last update: 2012-09-07 04:41    [W:0.159 / U:2.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site