Messages in this thread | | | Date | Fri, 7 Sep 2012 09:59:01 +0800 | From | Mark Brown <> | Subject | Re: [PATCH V3] regulator: disable supply regulator if it is enabled for boot-on |
| |
On Mon, Sep 03, 2012 at 07:55:39PM +0530, Laxman Dewangan wrote:
> + /* If supply enabled during registrtaion then need to disable > + * when full constraint enabled. > + */ > + unsigned int need_supply_disable:1;
I don't understand why we need this flag. Shouldn't we just be making the reference counts for the supplies correct and then have the regulator disabled in the late initcall as a result of its refcount falling to zero when the children are disabled? I think what we need to do here is always take a reference to the supply if the child is enabled during boot, then in the initcall we can just disable the parent regulator as normal.
| |