lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial_core: fix sizeof(pointer)
On Thu, Sep 06, 2012 at 08:59:00AM +0200, Jiri Slaby wrote:
> On 09/06/2012 04:27 AM, Fengguang Wu wrote:
> > sizeof when applied to a pointer typed expression gives the
> > size of the pointer.
> >
> > Generated by: scripts/coccinelle/misc/noderef.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > cocci-output-38612-39d907-serial_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/tty/serial/serial_core.c
> > +++ b/drivers/tty/serial/serial_core.c
> > @@ -640,7 +640,7 @@ static void uart_get_info(struct tty_por
> > {
> > struct uart_port *uport = state->uart_port;
> >
> > - memset(retinfo, 0, sizeof(retinfo));
> > + memset(retinfo, 0, sizeof(*retinfo));
>
> Hmm, what tree is this against? I have:

It's the tty:tty-next tree.

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next

> memset(&tmp, 0, sizeof(tmp));

Oh I didn't know it's a new bug introduced by commit

commit 7ba2e769825fef035a943ed74d90379245508764
Author: Alan Cox <alan@linux.intel.com>
AuthorDate: Tue Sep 4 16:34:45 2012 +0100
Commit: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitDate: Wed Sep 5 13:11:03 2012 -0700

tty: Split the serial_core helpers for setserial into two

Thanks,
Fengguang


\
 
 \ /
  Last update: 2012-09-06 09:41    [W:0.091 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site