Messages in this thread | | | Subject | Re: [PATCH] trace: Don't declare trace_*_rcuidle functions in modules | From | Steven Rostedt <> | Date | Thu, 06 Sep 2012 15:49:10 -0400 |
| |
On Tue, 2012-09-04 at 23:23 -0700, Josh Triplett wrote: > Tracepoints declare a static inline trace_*_rcuidle variant of the trace > function, to support safely generating trace events from the idle loop. > Module code never actually uses that variant of trace functions, because > modules don't run code that needs tracing with RCU idled. However, the > declaration of those otherwise unused functions causes the module to > reference rcu_idle_exit and rcu_idle_enter, which RCU does not export to > modules. > > To avoid this, don't generate trace_*_rcuidle functions for tracepoints > declared in module code. > > Reported-by: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
| |