Messages in this thread | | | Date | Thu, 6 Sep 2012 20:06:11 +0200 | Subject | Re: linux-next: build failure after merge of the final tree (staging tree related) | From | Geert Uytterhoeven <> |
| |
On Wed, Sep 5, 2012 at 7:48 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id': > drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration] > drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration] > > Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during > device registration"). > > I have added the following patch for today: > > From: Stephen Rothwell <sfr@canb.auug.org.au> > Date: Wed, 5 Sep 2012 15:44:11 +1000 > Subject: [PATCH] Staging: ipack: disable due to build error > > The powerpc allyesconfig build gives this: > > drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id': > drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration] > drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]
The ipack driver also fails on s390/allmodconfig:
drivers/staging/ipack/devices/ipoctal.c:59:2: error: implicit declaration of function 'iowrite8' [-Werror=implicit-function-declaration] drivers/staging/ipack/devices/ipoctal.c:72:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
http://kisskb.ellerman.id.au/kisskb/buildresult/7143741/
Guess it has to depend on HAS_IOMEM, too.
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > --- > drivers/staging/ipack/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig > index af32178..5c428d7 100644 > --- a/drivers/staging/ipack/Kconfig > +++ b/drivers/staging/ipack/Kconfig > @@ -4,6 +4,7 @@ > > menuconfig IPACK_BUS > tristate "IndustryPack bus support" > + depends on BROKEN
Cool, can I do that for all build failures? ;-)
> ---help--- > If you say Y here you get support for the IndustryPack Framework > for drivers for many types of boards that support this industrial
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |