lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [mcelog] Start using the new sysfs tunables location
On Thu, 06 Sep 2012 18:04:27 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:

> On 09/06/2012 05:58 PM, Andi Kleen wrote:
> >> The change is still under discussion. Stage one is to add the new global
> >> pathnames in addition to keeping the old per-cpu ones. Also fix all utilities
> >> (just mcelog(8) as far as we know) to prefer the new paths.
> >
> > But why do you even want to change it? Does it fix anything?
> > AFAIK the old setup -- while not being pretty -- works just fine.
>
> The reason for this was explained in this thread:
> http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg298302.html
>
> Even if we decide not to remove these tunables from under their current
> per-cpu location, I still think it is much cleaner to have them
> available under /sys/devices/system/machinecheck.

That to me seems a ridiculous proposal. What are you going to do if in
future they ceased to be system wide ? Move them back ?

The threshold for playing musical chairs with sysfs nodes is a lot higher
than "I think it's much cleaner"

The current approach is a lot more futureproof even if a spot more ugly.

Alan


\
 
 \ /
  Last update: 2012-09-06 15:22    [W:0.047 / U:3.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site