lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] swim: Add missing spinlock init
From
On Thu, Sep 6, 2012 at 1:48 PM, Jean Delvare <khali@linux-fr.org> wrote:
> It doesn't seem this spinlock was properly initialized.

Quiet possible. There's no SMP on m68k, so all spinlock ops expand to nothing.

> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Finn Thain <fthain@telegraphics.com.au>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> I can't even build-test this.
>
> drivers/block/swim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-3.6-rc4.orig/drivers/block/swim.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/block/swim.c 2012-09-06 13:09:26.713382169 +0200
> @@ -845,6 +845,7 @@ static int __devinit swim_floppy_init(st
> swd->unit[drive].swd = swd;
> }
>
> + spin_lock_init(&swd->lock);
> swd->queue = blk_init_queue(do_fd_request, &swd->lock);
> if (!swd->queue) {
> err = -ENOMEM;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2012-09-06 14:42    [W:0.072 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site