Messages in this thread | | | Date | Thu, 06 Sep 2012 12:21:15 +0900 | From | "Jun'ichi Nomura" <> | Subject | Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info |
| |
On 09/06/12 05:27, Kent Overstreet wrote: > @@ -2718,7 +2705,8 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity) > if (!pools->tio_pool) > goto free_io_pool_and_out; > > - pools->bs = bioset_create(pool_size, 0); > + pools->bs = bioset_create(pool_size, > + offsetof(struct dm_rq_clone_bio_info, clone)); > if (!pools->bs) > goto free_tio_pool_and_out;
frontpad is not necessary if type is DM_TYPE_BIO_BASED.
Other pool creation in that function do something like: pools->bs = (type == DM_TYPE_BIO_BASED) ? bioset_create(pool_size, 0) : bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone));
-- Jun'ichi Nomura, NEC Corporation
| |