lkml.org 
[lkml]   [2012]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3.6 0/3] Fix use-after-free in PSCSI
From
Date
On Wed, 2012-09-05 at 17:09 +0200, Paolo Bonzini wrote:
> Hi,
>
> this series fixes the bug I reported with wrong sense data. The
> memory corruption is caused by using the sense data after freeing
> it. The series corrects it by moving the copy of the sense data
> earlier, to the transport_complete callback.
>
> Please review and be kind on my first lio patches! :)
>
> Paolo
>
> Paolo Bonzini (3):
> target: move transport_get_sense_data
> target: simplify code around transport_get_sense_data
> target: fix use-after-free with PSCSI sense data
>
> drivers/target/target_core_pscsi.c | 21 ++----
> drivers/target/target_core_transport.c | 117 ++++++++++++--------------------
> include/target/target_core_backend.h | 4 +-
> 3 files changed, 53 insertions(+), 89 deletions(-)
>

The approach to squash the bug looks easonable to me, and nice work on
the extra cleanups for backend sense w/ TRANSPORT_PLUGIN_PHBA_PDEV !

I've applied this to target-pending/master w/ CC stable, and will plan
to send out the PULL request for -rc5 over the next days.

Nice work Paolo!

--nab



\
 
 \ /
  Last update: 2012-09-06 03:22    [W:0.143 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site