Messages in this thread | | | Subject | Re: [PATCH v5 3/3] powerpc: Uprobes port to powerpc | From | Benjamin Herrenschmidt <> | Date | Wed, 05 Sep 2012 15:26:59 +1000 |
| |
On Fri, 2012-08-24 at 13:01 +0530, Ananth N Mavinakayanahalli wrote: > From: Ananth N Mavinakayanahalli <ananth@in.ibm.com> > > This is the port of uprobes to powerpc. Usage is similar to x86.
Guys, can you do a minimum of build testing ?
This one breaks due to uprobe_get_swbp_addr() being defined in both asm and include/linux when CONFIG_UPROBE isn't set. You don't need to define it at all in fact, the generic code takes care of both the declaration for CONFIG_UPROBE and the empty inline for !CONFIG_UPROBE.
I'm fixing that one up myself but please, please, get yourself a test build script or something to make sure you don't at least break the build when the stuff you're adding isn't enabled (among others).
Cheers, Ben.
| |