Messages in this thread Patch in this message | | | From | yan <> | Subject | [PATCH 2/3 v2] proc : no need to initialize proc_inode->fd in proc_get_inode | Date | Wed, 5 Sep 2012 20:17:16 +0800 |
| |
proc_get_inode() obtains the inode via a call to iget_locked(). iget_locked() calls alloc_inode() which will call proc_alloc_inode() which clears proc_inode.fd, so there is no need to clear this field in proc_get_inode().
If iget_locked() instead found the inode via find_inode_fast(), that inode will not have I_NEW set so this change has no effect.
Signed-off-by: yan <clouds.yan@gmail.com> --- fs/proc/inode.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 7ac817b..3b22bbd 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c @@ -450,7 +450,6 @@ struct inode *proc_get_inode(struct super_block *sb, struct proc_dir_entry *de) return NULL; if (inode->i_state & I_NEW) { inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; - PROC_I(inode)->fd = 0; PROC_I(inode)->pde = de; if (de->mode) { -- 1.7.9.5
| |