Messages in this thread | | | Subject | Re: [PATCH] perf: allow user to indicate path to objdump in command line | From | Maciek Borzecki <> | Date | Wed, 05 Sep 2012 07:22:44 +0200 |
| |
On Wed, 2012-09-05 at 12:11 +1000, Michael Ellerman wrote: > On Tue, 2012-09-04 at 10:05 -0600, David Ahern wrote: > > On 9/4/12 4:32 AM, Maciek Borzecki wrote: > > > When analyzing perf data from hosts of other architecture than one of the local > > > host it's useful to call objdump that is part of a toolchain for that > > > architecture. Instead of calling regular objdump, call one that user specified > > > in command line. > > > > Why not set the PATH to make the toolchain's version the one used by perf? > > At least one reason is that cross toolchains are usually built such that > the resulting binaries are called <target>-objdump, <target>-gcc etc. Correct, PATH won't work. First I thought, why not hardcode objdump based on CROSS. But then, I'd need to rebuild perf for each toolchain, bad idea. Passing objdump in command line seems like a good compromise to me, especially as I haven't noticed any other binutils tools to be used by perf same way as objdump is.
-- Maciek Borzecki <maciek.borzecki@gmail.com>
| |