Messages in this thread | | | Date | Tue, 4 Sep 2012 19:06:37 +0900 | Subject | Re: [PATCH v2] udf: extent cache implementation for manipulating block map | From | Namjae Jeon <> |
| |
2012/9/4 Jan Kara <jack@suse.cz>: > On Tue 04-09-12 16:45:42, Namjae Jeon wrote: >> 2012/9/3, Jan Kara <jack@suse.cz>: >> >> +void udf_clear_extent_cache(struct udf_inode_info *iinfo) >> >> +{ >> >> + if (iinfo->cached_extent.sanity) { >> >> + brelse(iinfo->cached_extent.epos.bh); >> >> + memset(&iinfo->cached_extent, 0, sizeof(struct udf_ext_cache)); >> >> + } >> >> +} >> >> + >> > I think udf_clear_entent_cache() should take i_extent_cache_lock. Or if >> > you are sure it's not needed, you need a good documentation why. >> Documentation ? I am a little confusing.. It means udf.txt is in >> Documentation/filesystem/ ? >> or comment about clear extent function ? > I meant in a comment before udf_clear_extent_cache() function... Okay, I understood. Thanks a lot. > > Honza > -- > Jan Kara <jack@suse.cz> > SUSE Labs, CR
| |