lkml.org 
[lkml]   [2012]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC v2 4/7] modsig: add integrity_module_check hook
    Date
    Dmitry Kasatkin <dmitry.kasatkin@intel.com> writes:
    > +#else
    > +static inline int integrity_module_check(const void *buf, unsigned long len)
    > +{
    > + return 0;
    > +}
    > +#endif

    ...

    > + err = integrity_module_check(hdr, len);
    > + if (err < 0)
    > + goto free_hdr;
    > +
    > + /* cut signature tail */
    > + info->len = err;

    This is a bug.

    Firstly, you want the 'long' not 'int' as the return vale from
    integrity_module_check(). But mainly, you want it to return 'len' not
    0.

    I'd also prefer it to be *immediately* after we copy from userspace.

    Cheers,
    Rusty.


    \
     
     \ /
      Last update: 2012-09-04 08:41    [W:3.055 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site