Messages in this thread | | | Date | Wed, 5 Sep 2012 00:56:33 +0200 | From | Andrea Arcangeli <> | Subject | Re: [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type |
| |
Hi Gerald,
On Wed, Aug 29, 2012 at 05:32:58PM +0200, Gerald Schaefer wrote: > +#ifndef __HAVE_ARCH_PGTABLE_DEPOSIT > +extern void pgtable_deposit(struct mm_struct *mm, pgtable_t pgtable); > +#endif
One minor nitpick on the naming of the two functions: considering that those are global exports, that they can only be used by THP and they mangle internally with the mm->pmd_huge_pte field (also only defined if TRANSPARENT_HUGEPAGE=y), a more specific THP naming may be clearer.
If the current prepare_pmd_huge_pte/get_pmd_huge_pte wasn't good other options could be pgtable_trans_huge_deposit/withdraw.
| |