Messages in this thread | | | Date | Mon, 3 Sep 2012 08:43:10 +0300 | Subject | Re: [PATCH -v2 12/13] x86, mm: Use func pointer to table size calculation and mapping. | From | Pekka Enberg <> |
| |
On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu <yinghai@kernel.org> wrote: > +static void __init with_all_ram_ranges( > + void (*work_fn)(unsigned long, unsigned long, void *), > + void *data)
> +static void __init size_work_fn(unsigned long start, unsigned long end, void *data)
> +static void __init mapping_work_fn(unsigned long start, unsigned long end, > + void *data)
So I passionately hate the naming convention. How about something similar to mm/pagewalk.c:
s/with_all_ram_ranges/walk_ram_ranges/g
s/size_work_fn/table_space_size/g
s/mapping_work_fn/map_memory/g
| |