lkml.org 
[lkml]   [2012]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -v2] mm: frontswap: fix a wrong if condition in frontswap_shrink
From
Date
On Sat, 2012-09-29 at 10:54 +0800, Zhenzhong Duan wrote:
> On 2012-09-28 22:54, Paul Bolle wrote:
> > Not even before applying your patch? Anyhow, after applying your patch
> > the warnings gone here too.
> I tested both cases, no warning, also didn't see -Wmaybe-uninitialized
> when make.
> My env is el5. gcc version 4.1.2 20080704 (Red Hat 4.1.2-52)
> Maybe your gcc built in/implicit spec use that option?

I simply use what (was and) is shipped by Fedora 17:
$ sudo grep -w gcc /var/log/yum.log
Sep 12 11:45:54 Installed: gcc-4.7.0-5.fc17.x86_64
Sep 27 13:54:24 Updated: gcc-4.7.2-2.fc17.x86_64

So I did my patch with a version of GCC's release 4.7.0, and tested your
patch with a version of GCC's 4.7.2 release.

I don't think I tweaked any settings. Unless there are strong reasons to
do otherwise, I try to use the tools shipped by Fedora in their default
settings. (I'm not even sure there's a way to set one's GCC settings
locally.)


Paul Bolle



\
 
 \ /
  Last update: 2012-09-29 11:21    [W:0.044 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site